Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filename and path to workflows #687

Closed

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 4, 2023

Ref: ManageIQ/manageiq-ui-classic#8715 (comment)

@Fryguy not sure about the naming, maybe source_filename and source_path ?

@Fryguy
Copy link
Member

Fryguy commented Apr 6, 2023

I assume this is for git-based workflows. What would we do if there were authoring in the future? Would these just be blank? Asking because we considered using this for namespacing / unique identification.

@agrare
Copy link
Member Author

agrare commented Apr 6, 2023

Yes this is for git-based workflows, if they are not using git then these would be blank and the name would be the only present component for uniqueness. In this case we would be the single-source-of-truth and we can control name collisions prior to saving.

@Fryguy
Copy link
Member

Fryguy commented Apr 6, 2023

we can control name collisions prior to saving.

That's a good point. On that note, do we have a distinction between name and description in that table?

@agrare
Copy link
Member Author

agrare commented Apr 6, 2023

On that note, do we have a distinction between name and description in that table?

No description currently, so proposal is:

  1. Description becomes the workflow "Comment" (which is currently being set as name)
  2. Name becomes unique, and is either "repo/branch/file_path" for git-based or just a name locally authored workflows?

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2023

Checked commits agrare/manageiq-schema@2346429~...05ece57 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare closed this May 10, 2023
@agrare agrare deleted the add_file_name_file_path_to_workflows branch May 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants