Add specs for nic_settings customization #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
add_specs_customization_nic_settings
branch
from
049b18d to
0421166
Compare
agrare
commented
Nov 12, 2024
| @@ -110,8 +110,11 @@ def collect_nic_settings | |||
| nics = Array.wrap(options[:nic_settings]) | |||
| nic = nics[0] | |||
| nic = {} if nic.blank? | |||
| [:dns_domain, :dns_servers, :sysprep_netbios_mode, :wins_servers, :addr_mode, | |||
| :gateway, :subnet_mask, :ip_addr].each { |key| nic[key] = options[key] } | |||
There was a problem hiding this comment.
NOTE setting nic[key] = options[key] without checking if nic[key] is set already was causing the first entry in the nic_settings array to be overwritten with all nils so you had to duplicate the first nic's values like:
:nic_settings = [{:ip_addr => "1.2.3.4"}],
:ip_addr => "1.2.3.4"
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Nov 14, 2024
Add specs for nic_settings customization (cherry picked from commit a802321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started out just writing specs covering the various cases, found an issue where when I used a
options[:nic_settings]array I had to duplicate the values in the first nic settings entry at the root level of the options hash as well otherwise it would be overwritten withnil