Continue refresh if cis_connect fails #917
Conversation
|
How will we know if it's having trouble connecting though? Is there like a warning we can issue in the UI or on the authentication? Maybe put refresh status to yellow? I didn't mind merging as is, but I am concerned this will "hide" real issues. |
|
I can log a warning, I don't think we have a way to set the refresh status to "warning" though. We have last_refresh_error nil or present and the UI shows a warning if there are no errors but the last_refresh_date is > N days ago |
agrare
force-pushed
the
handle_cis_connect_failure
branch
from
9b13395 to
1708722
Compare
|
Checked commit agrare@1708722 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Might be interesting to have a last_refresh_warning and be able to show warning status. Or perhaps last_refresh_error plus success is interpreted as a warning. This is fine for now though. |
|
Yeah I was thinking we could replace last_refresh_error (which has the message) to last_refresh_status=success/error/warning and last_refresh_message |
|
Backported to |
Continue refresh if cis_connect fails (cherry picked from commit 097e546)
The CIS vsphere-automation endpoint allows us to get tags and content libraries that aren't present in the VIM API. If there is a failure connecting to this endpoint for whatever reason we shouldn't fail the rest of the refresh.