Add supports storage smartstate_analysis #887
Conversation
| @@ -1,3 +1,5 @@ | |||
| class ManageIQ::Providers::Vmware::InfraManager::Storage < ManageIQ::Providers::InfraManager::Storage | |||
| include ManageIQ::Providers::Vmware::InfraManager::EmsRefObjMixin | |||
|
|
|||
| supports :smartstate_analysis | |||
There was a problem hiding this comment.
@nasark do we need to also check storage.nil? and https://github.com/ManageIQ/manageiq-providers-ovirt/pull/653/files#diff-24aea1f97754a89593e8311e8ea2bf2d897a159336d1f1c578d17fbb1964506dR10 here?
|
@nasark We're dropping the |
nasark
force-pushed
the
add_supports_storage_smartstate_analysis
branch
2 times, most recently
from
9d80a56 to
970b225
Compare
|
@miq-bot add_label quinteros/yes? |
|
|
||
| supports :smartstate_analysis do | ||
| if nil? | ||
| unsupported_reason_add(:smartstate_analysis, "Storage not found") | ||
| end | ||
| unless storage_type_supported_for_ssa? | ||
| unsupported_reason_add(:smartstate_analysis, "Smartstate Analysis unsupported for storage type %{store_type}" % {:store_type => store_type}) | ||
| end | ||
| end |
There was a problem hiding this comment.
I think this needs to live in app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/scanning.rb (where storage.nil? would make sense, just nil? here doesn't do anything since the current object can't be nil here)
nasark
force-pushed
the
add_supports_storage_smartstate_analysis
branch
from
970b225 to
7bc493b
Compare
|
|
||
| supports :smartstate_analysis do | ||
| if nil? | ||
| unsupported_reason_add(:smartstate_analysis, "Storage not found") | ||
| elsif !storage_type_supported_for_ssa? | ||
| unsupported_reason_add(:smartstate_analysis, "Smartstate Analysis unsupported for storage type %{store_type}" % {:store_type => store_type}) | ||
| end | ||
| end |
There was a problem hiding this comment.
I don't think we need this, storage smartstate is different and the store_type shouldn't matter (plus if nil? doesn't make sense)
nasark
force-pushed
the
add_supports_storage_smartstate_analysis
branch
from
7bc493b to
573100d
Compare
|
Checked commit nasark@573100d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Backported to |
…nalysis Add supports storage smartstate_analysis (cherry picked from commit 1c73716)
Core has been changed to use
supports_notand since vmware is the only provider that supports storage scans this is needed here@miq-bot add_label bug
@miq-bot assign @agrare