Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Array.wrap over Object#to_miq_a #602

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Prefer Array.wrap over Object#to_miq_a #602

merged 2 commits into from
Jul 17, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 16, 2020 •
edited
Loading

@bdunne bdunne requested review from agrare and Fryguy as code owners July 16, 2020 15:39
@miq-bot
Copy link
Member

miq-bot commented Jul 16, 2020

Checked commits bdunne/manageiq-providers-vmware@abd6096~...0524b6c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
5 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member

agrare commented Jul 16, 2020

So I know at some point to_miq_a was used to handle some specific VMware SDK issues but it looks like that might have changed with at least ManageIQ/manageiq-gems-pending@77cfb7d#diff-77a9c289868d1538eba1ac263afe32fd ?

There's no doubt that today .to_miq_a is just Array.wrap and if we do end up needing to "handle some SOAP (lol get it handsoap) we should do that in this repo or vmware_web_service, @Fryguy wdyt?

@bdunne
Copy link
Member Author

bdunne commented Jul 16, 2020

Yeah, I was trying to clean up callers where they looked like they are object arrays so that I could deprecate the to_miq_a methods and figure out the rest. I can drop any of these changes if you think they might be multi-line strings.

@bdunne
Copy link
Member Author

bdunne commented Jul 16, 2020

@miq-bot add_label technical debt

@agrare agrare merged commit 959e48c into ManageIQ:master Jul 17, 2020
@bdunne bdunne deleted the to_miq_a branch July 17, 2020 12:32
@bdunne bdunne mentioned this pull request Jul 22, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@agrare agrare

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunne @miq-bot @agrare