Rails 6.0 #663
Rails 6.0 #663
Conversation
NickLaMuro
requested review from
agrare,
andyvesel,
aufi,
Fryguy and
mansam
as code owners
.parent is deprecated in Rails 6, so use it's replacement .module_parent
|
Checked commits NickLaMuro/manageiq-providers-openstack@cb5497b~...2b20c81 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
| @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency "activesupport", "~> 5.2.4", ">= 5.2.4.3" | |||
There was a problem hiding this comment.
Can we apply https://github.com/ManageIQ/activerecord-id_regions/pull/18/files#r537735807 here as well?
There was a problem hiding this comment.
I don't see why we would, as this isn't a gem that ever needs to be released, and is only used by ManageIQ/manageiq, which now requires Rails 6. The only place where I think this does make sense is in gems that are released to rubygems.org or rubygems.manageiq.org which this is not.
(This is going to be a carbon copy answer that I will be pasting in all provider repos where this comment exists)
There was a problem hiding this comment.
I still look at the provider plugins like they are regular gems and question why a gem would have a tight dependency like this unless something in the code base requires that tight dependency.
There was a problem hiding this comment.
If this was a more broken out plugin, where customers could add gems as they see fit, we would probably have a manageiq-core gem that plugins would instead be consuming, which would probably be tightly coupled to a version of Rails.
I see this dependency as a gemspec version of that for now, where in reality, it really is being done as part of bin/update and the dependency of spec/manageiq being required to run anything in this repo standalone at the moment.
Links