Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new resource pool cpu_core_* columns #147

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Use new resource pool cpu_core_* columns #147

merged 3 commits into from
Oct 25, 2023

Conversation

jaywcarman
Copy link
Member

@jaywcarman jaywcarman mentioned this pull request Oct 23, 2023
Merged
@agrare
Copy link
Member

agrare commented Oct 25, 2023

@jaywcarman can you add a spec test checking the new values?

@jaywcarman jaywcarman force-pushed the add_cpu_cores_columns_to_resource_pools branch from b92e4e2 to abe0ab7 Compare October 25, 2023 18:14
@agrare agrare closed this Oct 25, 2023
@agrare agrare reopened this Oct 25, 2023
@agrare agrare self-assigned this Oct 25, 2023
@agrare agrare added the enhancement New feature or request label Oct 25, 2023
@agrare agrare merged commit b5bf4c1 into ManageIQ:master Oct 25, 2023
@jaywcarman jaywcarman deleted the add_cpu_cores_columns_to_resource_pools branch October 25, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@iv1111 iv1111 Awaiting requested review from iv1111

Assignees

@agrare agrare

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaywcarman @agrare