Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove miq_tempfile.rb #469

Merged
merged 1 commit into from
May 14, 2020
Merged

Remove miq_tempfile.rb #469

merged 1 commit into from
May 14, 2020

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 8, 2020

Followup to ManageIQ/manageiq-smartstate#124.

Part of #231.

@djberg96
Copy link
Contributor Author

djberg96 commented May 8, 2020

@miq-bot add_reviewer @bdunne

@miq-bot miq-bot requested a review from bdunne May 8, 2020 20:59
@miq-bot
Copy link
Member

miq-bot commented May 8, 2020

Checked commit https://github.com/djberg96/manageiq-gems-pending/commit/81b4b921ddb4fdebd85b7be4c1d2350795baef5f with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member

Fryguy commented May 12, 2020

This will require a smart-state version bump and inclusion, so can't merge until those PRs are created.

@agrare
Copy link
Member

agrare commented May 14, 2020

Okay smartstate v0.5.8 released with ManageIQ/manageiq-smartstate#124

@agrare agrare merged commit 0bc28c5 into ManageIQ:master May 14, 2020
@Fryguy Fryguy mentioned this pull request May 15, 2020
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants