Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list of URLs to avoid maintenance #1712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jan 9, 2023

@bdunne Please review.

In this example, we will update from jansa to kasparov.

1. Ensure that the appliance is up to date on the current branch

# dnf update

2. Install the new manageiq-release RPM for the version that you want to upgrade to. Refer to ([RPM URLs for manageiq-release](#rpm-urls-for-manageiq-release)) for the list of RPM URLs
2. Install the new manageiq-release RPM for the version that you want to upgrade to. Refer to the [release directory](https://rpm.manageiq.org/index.html?prefix=release/) in our RPM repository to find the latest manageiq-release rpm. The number is the alphabetical number of the release (e.g. j (jansa) is the 10th letter: 10-jansa, k (kasparov) is the 11th letter: 11-kasparov, etc.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to generate some other URL that links to the release rpm directly? Maybe something like https://rpm.manageiq.org/15.rpm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like a redirect URL? or actual RPM location.

Copy link
Member

@bdunne bdunne Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would be a copy of the actual RPM (since we can't do rewrites or redirects with the current hosting)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but let's discuss in a separate issue. For now, I want to just remove the existing URLs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created ManageIQ/manageiq-rpm_build#367 to discuss there.

@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Jul 17, 2023
@bdunne bdunne reopened this Jul 17, 2023
@bdunne bdunne added pinned and removed stale labels Jul 17, 2023
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2023

Checked commit Fryguy@f56ca40 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member Author

Fryguy commented Jul 17, 2023

@bdunne Since this was reopened should we merge? I assumed you didn't want this change, and we already have ManageIQ/manageiq-rpm_build#367

@bdunne
Copy link
Member

bdunne commented Jul 17, 2023

I reopened because I didn't want it to get lost. We can close in favor of ManageIQ/manageiq-rpm_build#367 if you prefer to do that.

@Fryguy
Copy link
Member Author

Fryguy commented Mar 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants