Fix CloudNetworks spec with empty including() #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrare should the tests be passing? 😕 |
No, this only fixes the cloud_networks spec not the resource_pool identifier issue. |
Fryguy
approved these changes
Aug 30, 2024
|
Merging. We have other 🔴 failures to be fixed outside of this PR. |
|
Marked for radjabov/yes? since we can pull in rspec-expectations 3.13.2 on that branch too. |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Sep 4, 2024
…including Fix CloudNetworks spec with empty including() (cherry picked from commit 4e4e1a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec was unchanged since being introduced in fa4e0a6 but a bump to rspec-expectations
3.13.2raised the issue that it wasn't actually testing anything.