Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BERT score [WIP] #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding BERT score [WIP] #76

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2019

For #75

BERT score added, but not tested yet.

This is still WIP, I don't have a Linux instance with GPU to test it yet.

Dependencies :

  • pytorch
  • bert-score

TODO

  • Check if the added test is running fine
  • Update other tests
  • Update README with new dependencies

@@ -152,6 +155,7 @@ class NLGEval(object):
'Bleu_1', 'Bleu_2', 'Bleu_3', 'Bleu_4',
'METEOR',
'ROUGE_L',
'BERT_score'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comma missing at the end of the line.

@juharris
Copy link
Member

juharris commented Jul 8, 2019

Thank you for your contribution!

Would you add the new requirements to requirements_py2.txt and requirements.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants