Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always forward parent attributes #4813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

always forward parent attributes #4813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b59292
always forward parent attributes, closing #4686
SimonDanisch Dec 23, 2024
baddf44
Merge branch 'master' into sd/fix-specapi-attributes
SimonDanisch Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/specapi.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,13 +595,14 @@ function diff_plotlist!(
for plotspec in plotspecs
# we need to compare by types with compare_specs, since we can only update plots if the types of all attributes match
reused_plot, old_spec = find_reusable_plot(scene, plotspec, reusable_plots, scores)
# Forward kw arguments from Plotlist
if !isnothing(plotlist)
merge!(plotspec.kwargs, plotlist.kw)
end
if isnothing(reused_plot)
# Create new plot, store it into our `cached_plots` dictionary
@debug("Creating new plot for spec")
# Forward kw arguments from Plotlist
if !isnothing(plotlist)
merge!(plotspec.kwargs, plotlist.kw)
end

# This is all pretty much `push!(scene, plot)` / `plot!(scene, plotobject)`
# But we want the scene to only contain one PlotList item with the newly created
# Plots from the plotlist to only appear as children of the PlotList recipe
Expand Down
Loading