-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate space
from transformations
#4792
Draft
ffreyer
wants to merge
30
commits into
master
Choose a base branch
from
ff/space
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsSHA: e1b45fa1352c31dc0978cca2ec1e20f1217f6652 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
this is handled in plot construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3796
This pr removes
space
from transformations and adds more convenience inputs to thetransformation
attribute, as suggested in #4750.The goal of this is to give
space
a clear and well defined scope - that of "projections", i.e. coordinate spaces that could be handled by a camera. "Transformations", i.e. the model matrix and transform function (or scale in Axis) are completely cut off fromspace
here. They would instead be handled through thetransformation
attribute which now accepts:automatic, :auto, :automatic
: inherit transformations from parent based onspace
compatibility:inherit
: inherit transformations regardless of space compatibility:inherit_model
: inherit just the model matrix (i.e. rotate!(), scale!(), translate!()) regardless of space compatibility:inherit_transform_func, :inherit_transform_function
: inherit just transform function regardless of space compatibilitynothing, identity, :nothing, :identity
: no inheritance, create new identity transformationPrevious options such as an explicit
Transformation()
and arguments fortransform()
(e.g.:xy
,(translate = (1,2,3),)
) continue to work. The latter assumesautomatic
for the inheritance setting.(inheritance_option, transform_arg)
is currently also allowed.TODO:
renamecurrently vetod by Simonspace = :data
to:world
space
documentationtransformation
attributetransform!()
functionsspaces()
Tangential changes:
is_..._space()
to work with Observable and plot inputsspace
handling to rely onis_..._space()
more and assumeplot.space
exists when it should (i.e. for primitive plots mostly in backends)Type of change
Checklist