Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Block.attri... to autocomplete #4786

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Allow Block.attri... to autocomplete #4786

merged 6 commits into from
Feb 19, 2025

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Feb 12, 2025

Description

Fixes #3749

This adds autocompletion on Block types. I'm not sure if these should exist, because e.g. Axis.ytickalign doesn't exist (Axis is a type), but it is nice for querying docs ?Axis.ytickalign.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Feb 12, 2025

Benchmark Results

SHA: 98b6693a8bedf1459ce7f259867b0165e302aca1

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@SimonDanisch
Copy link
Member

Maybe add a quick test, to make sure the returned values are something that autocomplete can work with?

@ffreyer
Copy link
Collaborator Author

ffreyer commented Feb 18, 2025

This is done btw. I just left it as a draft because I'm not sure if we want it.

Maybe add a quick test, to make sure the returned values are something that autocomplete can work with?

I tested in the terminal. I guess we could have @test propertynames(Axis) isa NTuple{N, Symbol} where N or whatever the type is?

@SimonDanisch
Copy link
Member

I tested in the terminal. I guess we could have @test propertynames(Axis) isa NTuple{N, Symbol} where N or whatever the type is?

Yes exactly, in case we slightly change the returntype or so, since that function is internal and might change the returned values anytime ;)

@ffreyer ffreyer marked this pull request as ready for review February 18, 2025 14:59
@ffreyer ffreyer merged commit 65495fa into master Feb 19, 2025
22 checks passed
@ffreyer ffreyer deleted the ff/block-autocomplete branch February 19, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Autocomplete for Axis.x<TAB>
3 participants