Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting inspectable in the theme #4739

Merged
merged 6 commits into from
Feb 19, 2025
Merged

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Jan 18, 2025

Description

Fixes #4736 (issue)

Script to try:

using Pkg
pkg"activate --temp"
pkg"dev . ./GLMakie ./MakieCore"
using GLMakie
# set inspectable=false either in update_theme! of Figure:
# update_theme!(inspectable=false)
fig = Figure(inspectable=false)
# image() and first scatter() shouldn't be inspectable then:
image(fig[1,1], rand(3, 3))
scatter!(rand(10))
scatter!(rand(10), inspectable=true)
DataInspector(current_figure())
display(current_figure())
sleep(10)

Not sure if this change is testable with tests.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.

@aplavin
Copy link
Contributor Author

aplavin commented Jan 18, 2025

Not sure why the benchmark job is failing, seems unrelated.
As for changelog, can easily add an entry if needed – depends on whether it's considered a bugfix or a new feature.

@SimonDanisch
Copy link
Member

I'd add a changelog entry, since people should know that this is possible now!

@ffreyer
Copy link
Collaborator

ffreyer commented Feb 17, 2025

I'll do some cleanup

@ffreyer ffreyer merged commit a10db52 into MakieOrg:master Feb 19, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

not inspectable by default
3 participants