Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of usim.each #44

Merged
merged 4 commits into from
Sep 10, 2019
Merged

Conversation

eileen-kuehn
Copy link
Member

@eileen-kuehn eileen-kuehn commented Sep 9, 2019

This PR implements simplification of usim.each to be split into interval and delay.
The change include

  • code cleanup and functions for interval and delay,
  • adapted unit tests, and
  • adapted documentation.

Closes #42.

Copy link
Contributor

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I basically recommend changing the argument name to better match, and inlining the implementation into the interface.

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #44 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   97.04%   97.03%   -0.01%     
==========================================
  Files          21       21              
  Lines        1521     1519       -2     
  Branches      154      152       -2     
==========================================
- Hits         1476     1474       -2     
  Misses         33       33              
  Partials       12       12
Impacted Files Coverage Δ
usim/__about__.py 100% <ø> (ø) ⬆️
usim/_primitives/timing.py 99.24% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff719c...7f44d36. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #44 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   97.04%   97.02%   -0.02%     
==========================================
  Files          21       21              
  Lines        1521     1515       -6     
  Branches      154      152       -2     
==========================================
- Hits         1476     1470       -6     
  Misses         33       33              
  Partials       12       12
Impacted Files Coverage Δ
usim/__about__.py 100% <ø> (ø) ⬆️
usim/_primitives/timing.py 99.22% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff719c...7f44d36. Read the comment docs.

Copy link
Contributor

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eileen-kuehn eileen-kuehn merged commit 8515fd9 into master Sep 10, 2019
@eileen-kuehn eileen-kuehn deleted the feature/eachsimplification branch September 10, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename/simplify usim.each
2 participants