-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplification of usim.each
#44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I basically recommend changing the argument name to better match, and inlining the implementation into the interface.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.04% 97.03% -0.01%
==========================================
Files 21 21
Lines 1521 1519 -2
Branches 154 152 -2
==========================================
- Hits 1476 1474 -2
Misses 33 33
Partials 12 12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.04% 97.02% -0.02%
==========================================
Files 21 21
Lines 1521 1515 -6
Branches 154 152 -2
==========================================
- Hits 1476 1470 -6
Misses 33 33
Partials 12 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR implements simplification of
usim.each
to be split intointerval
anddelay
.The change include
interval
anddelay
,Closes #42.