Merge pull request #120 from MailOnline/next-release

Next release
MailOnline · Dec 10, 2018 · bb0c49a · bb0c49a
2 parents 81d3eb5 + 27fe4ed
commit bb0c49a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/vastSelectors/__tests__/index.spec.js b/src/vastSelectors/__tests__/index.spec.js
@@ -45,10 +45,10 @@ test('getVastErrorURI must return the error uri of the VAST element', () => {
 
 test('getAds must return the ads of the passed adResponse or null otherwise', () => {
   expect(getAds(wrapperParsedXML)).toEqual([wrapperAd]);
-  expect(getAds(noAdParsedXML)).toBe(null);
-  expect(getAds({})).toBe(null);
-  expect(getAds(null)).toBe(null);
-  expect(getAds()).toBe(null);
+  expect(getAds(noAdParsedXML)).toEqual([]);
+  expect(getAds({})).toEqual([]);
+  expect(getAds(null)).toEqual([]);
+  expect(getAds()).toEqual([]);
 });
 
 test('getFirstAd must return the first ad of the passed adResponse or null otherwise', () => {

diff --git a/src/vastSelectors/index.js b/src/vastSelectors/index.js
@@ -40,7 +40,7 @@ const compareBySequence = (itemA, itemB) => {
  *
  * @function
  * @param {ParsedVast} parsedVAST - Parsed VAST xml.
- * @returns {?Array} - Array of ads or `null`.
+ * @returns {?Array} - Array of ads or empty array.
  * @static
  * @ignore
  */
@@ -52,7 +52,7 @@ export const getAds = (parsedVAST) => {
     return ads;
   }
 
-  return null;
+  return [];
 };
 
 /**