Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ServiceMonitor #44

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Added ServiceMonitor #44

merged 2 commits into from
Oct 2, 2024

Conversation

Vovcharaa
Copy link
Contributor

Added ability to create ServiceMonitor for metrics scrapping.

Also, I believe it would be nice to deprecate prometheus key in values.yaml and move everything under metrics key.
Let me know whether to implement this change in this PR.

Tasks:

  • I've made changes
  • I've bumped chart's version in Chart.yaml
  • I've added changes to charts CHANGELOG.md
  • I've run helm-docs

@MaikuMori
Copy link
Owner

Also, I believe it would be nice to deprecate prometheus key in values.yaml and move everything under metrics key.

I see your point. I'd prefer to keep it as is because it mirrors Gotenberg's “modules” in the documentation. This way it's easier for me to flip between the docs and values, and I would hope that it's the same for users. Moreover, I prefer not to have breaking changes if we can avoid it.

It seems like it's failing tests. I can check what the issue is in a bit, but currently I'm a bit swamped.

I'm also wondering if it would make sense to add tests with Prometheus operator installed and metrics set to enable. Not necessary full e2e test, but just so that we can see that everything deploys without obvious errors.

Thank you, I definitely want to get this merged, after we deal with the issues.

@MaikuMori MaikuMori added this to the 1.7.0 milestone Sep 24, 2024
@MaikuMori
Copy link
Owner

I've created a 1.7.0 milestone, I will get all issues/PRs into that release. Probably by creating a 1.7.0 pull request and merging everything there, and then merging that into master once done.

@dkrizic dkrizic mentioned this pull request Sep 29, 2024
@Vovcharaa
Copy link
Contributor Author

@MaikuMori When can I expect this PR to be merged?

@MaikuMori MaikuMori changed the base branch from master to 1.7.0 October 2, 2024 03:04
@MaikuMori MaikuMori merged commit 0d3b13a into MaikuMori:1.7.0 Oct 2, 2024
0 of 6 checks passed
@MaikuMori
Copy link
Owner

@MaikuMori When can I expect this PR to be merged?

Now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants