Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ensemble property of moves object from being edited #52

Merged

Conversation

rsdefever
Copy link
Collaborator

@rsdefever rsdefever commented Apr 29, 2020

Prevents the ensemble attribute of the moves object from being edited after the moves object is created. The moves object contains default selections that are made based upon the ensemble that is selected when the object is initially created. Instead of allowing the user to edit the ensemble after the moves object has been created, this PR instead requires that the user create a new moves object if they wish to change ensembles.

Closes #50 , related to #3

Copy link
Collaborator

@rmatsum836 rmatsum836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I think preventing ensemble edits makes it much easier to verify that everything is correct before running a simulation.

@rsdefever
Copy link
Collaborator Author

Thanks for looking it over! Pretty simple change but I think the behavior makes sense.

@rsdefever rsdefever merged commit 5f77e57 into MaginnGroup:master May 1, 2020
@rsdefever rsdefever deleted the update/make-ensemble-immutable branch May 1, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent ensemble from being edited in Moves object once initialized
2 participants