A few fixes #15

Code0x58 · 2017-10-15T13:37:00Z

Here are a few fixes that I needed to get the code running smoothly locally:

disable caching while building
update uvloop version so there isn't an exception caused by a missing module/member in the containers
hammer away at the docker container to make sure it has stopped before another one tries to start
make sure only one type of benchmark is running at a time so the HTML formatting doesn't blow up, seemed reasonable (and simpler) to add a constraint
nice to have updated kb → KiB as kb wasn't kilobits
useful updated README.md to give versions for the required software that are known to work (including wrk which wasn't listed), and added a working example of run_benchmarks

run_benchmarks

Code0x58 · 2018-01-14T23:39:59Z

poke is this satisfactory now?

Code0x58 added 5 commits October 14, 2017 22:52

disable cache when building docker images

32f7def

Update uvloop to avoid exception

4e5290b

fudge to make sure container has been stopped

a5ababe

ensure a type of benchmark is selected so html report doesn't blow up

c4314cf

consistently use *iB

96b375a

Code0x58 force-pushed the master branch 3 times, most recently from c32589a to ab84058 Compare October 16, 2017 19:58

update and elaborate in README.rst

2ed20fc

Code0x58 force-pushed the master branch from ab84058 to 2ed20fc Compare October 16, 2017 20:00

elprans reviewed Oct 20, 2017

View reviewed changes

run_benchmarks Outdated Show resolved Hide resolved

move from using --benchmarks to positional args to filter benchmarks

a94f928

Provide feedback