Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[weather] add humidity to hourly view, fix spacing error when using UV Index, add config option to hide precipitation entries that are zero #3526

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

[weather] add humidity to hourly view, fix spacing error when using UV Index, add config option to hide precipitation entries that are zero #3526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
35b7d1d
Add humidity to hourly, fix spacing error with UV Index, add config o…
OWL4C Aug 29, 2024
8e9a814
Fix Indentation
OWL4C Aug 29, 2024
4cf4a55
Update CHANGELOG.md
OWL4C Aug 29, 2024
be1c6fb
Fix config option being wrongly defined hourly.njk
OWL4C Aug 29, 2024
5ae048a
Merge branch 'develop' into master
OWL4C Aug 29, 2024
209ab59
Added Humidity hourly class
OWL4C Sep 10, 2024
56b7ed5
Fixed Hourly Humidity
OWL4C Sep 10, 2024
1a1cd2d
Remove Spacer
OWL4C Sep 10, 2024
ebdb680
Merge branch 'develop' into master
OWL4C Sep 14, 2024
670dda9
Merge branch 'develop' into master
rejas Sep 15, 2024
e508516
Changed If clause
OWL4C Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ _This release is scheduled to be released on 2024-10-01._

### Added

- [weather] Added option Humidity to hourly View
- [weather] Added option to hide hourly entries that are Zero, hiding the entire column if empty.

### Removed

- [core] removed installer only files (#3492)
Expand All @@ -29,6 +32,7 @@ _This release is scheduled to be released on 2024-10-01._
- [weather] Fixed issue with the UK Met Office provider following a change in their API paths and header info.
- [core] add check for node_helper loading for multiple instances of same module (#3502)
- [weather] Fixed issue for respecting unit config on broadcasted notifications
- [weather] Fixed minor spacing issues when using UV Index in Hourly
- [tests] Fixes calendar test by moving it from e2e to electron with fixed date (#3532)

## [2.28.0] - 2024-07-01
Expand Down
20 changes: 15 additions & 5 deletions modules/default/weather/hourly.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{% if config.fade %}style="opacity: {{ currentStep | opacity(numSteps) }};"{% endif %}>
<td class="day">{{ hour.date | formatTime }}</td>
<td class="bright weather-icon">
<span class="wi weathericon wi-{{ hour.weatherType }}"></span>
<i class="wi weathericon wi-{{ hour.weatherType }}"></i>
</td>
<td class="align-right bright">
{{ hour.temperature | roundValue | unit("temperature") }}
Expand All @@ -21,15 +21,25 @@
{% endif %}
</td>
{% endif %}
{% if config.showHumidity %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the new config options to the defaults object at the top of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the defaults in the weather.js?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is a new config property, so it needs to havea default value set, and the defaults:{} object contains those
as documented in the developers guide for modules

<td class="align-left bright humidity-hourly">
{{ hour.humidity }}
<i class="wi wi-humidity humidity-icon"></i>
</td>
{% endif %}
{% if config.showPrecipitationAmount %}
<td class="align-right bright precipitation-amount">
{{ hour.precipitationAmount | unit("precip", hour.precipitationUnits) }}
</td>
{% if (!config.hideZeroes or hour.precipitationAmount>0) %}
<td class="align-right bright precipitation-amount">
{{ hour.precipitationAmount | unit("precip", hour.precipitationUnits) }}
</td>
{% endif %}
{% endif %}
{% if config.showPrecipitationProbability %}
{% if (!config.hideZeroes or hour.precipitationAmount>0) %}
<td class="align-right bright precipitation-prob">
{{ hour.precipitationProbability | unit('precip', '%') }}
{{ hour.precipitationProbability | unit('precip', '%') }}
</td>
{% endif %}
{% endif %}
</tr>
{% set currentStep = currentStep + 1 %}
Expand Down
1 change: 1 addition & 0 deletions modules/default/weather/weather.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

.weather .precipitation-amount,
.weather .precipitation-prob,
.weather .humidity-hourly,
.weather .uv-index {
padding-left: 20px;
padding-right: 0;
Expand Down
Loading