Skip to content

Commit

Permalink
Merge db/slice.cc into util/slice.cc
Browse files Browse the repository at this point in the history
Summary: It confuses some compilers to have slice.cc under multiple directories. Merge them.

Test Plan: Run existing tests

Reviewers: andrewkr, yhchiang, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D59409
  • Loading branch information
siying committed Jun 10, 2016
1 parent 5009b53 commit 6faddd7
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 26 deletions.
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ set(SOURCES
db/merge_helper.cc
db/merge_operator.cc
db/repair.cc
db/slice.cc
db/snapshot_impl.cc
db/table_cache.cc
db/table_properties_collector.cc
Expand Down
24 changes: 0 additions & 24 deletions db/slice.cc

This file was deleted.

1 change: 0 additions & 1 deletion src.mk
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ LIB_SOURCES = \
db/merge_helper.cc \
db/merge_operator.cc \
db/repair.cc \
db/slice.cc \
db/snapshot_impl.cc \
db/table_cache.cc \
db/table_properties_collector.cc \
Expand Down
14 changes: 14 additions & 0 deletions util/slice.cc
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,20 @@ int fromHex(char c) {
return c - 'A' + 10;
}

Slice::Slice(const SliceParts& parts, std::string* buf) {
size_t length = 0;
for (int i = 0; i < parts.num_parts; ++i) {
length += parts.parts[i].size();
}
buf->reserve(length);

for (int i = 0; i < parts.num_parts; ++i) {
buf->append(parts.parts[i].data(), parts.parts[i].size());
}
data_ = buf->data();
size_ = buf->size();
}

// Return a string that contains the copy of the referenced data.
std::string Slice::ToString(bool hex) const {
std::string result; // RVO/NRVO/move
Expand Down

0 comments on commit 6faddd7

Please sign in to comment.