Assorted fixes #3509
Merged
Assorted fixes #3509
+24
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mahrud
commented
Oct 6, 2024
mahrud
commented
- combined documentation of catch and throw
- fixed a typical value typo
- deleted duplicate code
- changed MonomialIdeal ^ ZZ to use BinaryPowerMethod
- removed dead code
- added lift and promote for IndexedVariable
d-torrance
reviewed
Oct 7, 2024
| Consequences => {{"the flow of control is passed to the surrounding ", TO "catch", ", and ", TT "x", " is returned as its value"}}, | ||
| document { | ||
| Key => {"throw", "catch"}, | ||
| Headline => "throw and catch exceptions", |
There was a problem hiding this comment.
Is "exception" the right term to use here? This makes it seem like these are used for dealing with errors.
There was a problem hiding this comment.
An exception doesn't have to be an error, you catch exceptions so they don't become errors (you can then choose to still signal an error in a perhaps more graceful way, but you can also just do something else instead to deal with the exception). Also the previous titles were "throw an exception" and "catch a thrown exception".
d-torrance
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.