Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that list is nonempty before calling factory function #3499

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

d-torrance
Copy link
Member

Otherwise we get a segfault

Before

i1 : debug Core

i2 : R = QQ[x];

i3 : rawIdealReorder raw matrix(R, {})
-- SIGSEGV
-* stack trace, pid: 1478018
 0# stack_trace(std::ostream&, bool) at /usr/src/macaulay2-1.24.05+git202409121006-0ppa202409120131~ubuntu24.04.1/M2/Macaulay2/d/main.cpp:132
 1# segv_handler at /usr/src/macaulay2-1.24.05+git202409121006-0ppa202409120131~ubuntu24.04.1/M2/Macaulay2/d/main.cpp:249
 2# 0x00007021FB445320 in /usr/lib/x86_64-linux-gnu/libc.so.6
 3# get_max_var(List<CanonicalForm> const&) in /usr/lib/x86_64-linux-gnu/libsingular-factory-4.3.2.so
 4# neworder(List<CanonicalForm> const&) in /usr/lib/x86_64-linux-gnu/libsingular-factory-4.3.2.so
 5# neworderint(List<CanonicalForm> const&) in /usr/lib/x86_64-linux-gnu/libsingular-factory-4.3.2.so
 6# rawIdealReorder at interface/factory.cpp:790
 7# interface_rawIdealReorder at /usr/src/macaulay2-1.24.05+git202409121006-0ppa202409120131~ubuntu24.04.1/M2/Macaulay2/d/interface.dd:1475

After

i3 : rawIdealReorder raw matrix(R, {})
stdio:3:15:(3): error: expected at least one generator

This is the underlying segfault behind #3497. I'm not sure if this is enough to fix the issue.

@pzinn: does the zero ideal have an irreducible characteristic series?

@mahrud mahrud requested a review from pzinn September 29, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant