Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename redundant type names #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Rename redundant type names #209

wants to merge 2 commits into from

Conversation

shu223
Copy link

@shu223 shu223 commented May 16, 2024

What

Renamed some redundant type names such as ChatCompletionMessageParam.ChatCompletionSystemMessageParam -> ChatCompletionMessageParam.SystemMessageParam.

Why

In Swift, the names of types within the nested structure usually omit the namespace prefix.

This fix improves the readability:

[Before]

  • ChatCompletionMessageParam.ChatCompletionSystemMessageParam
  • ChatCompletionMessageParam.ChatCompletionUserMessageParam
  • ChatCompletionMessageParam.ChatCompletionAssistantMessageParam
  • ChatCompletionMessageParam.ChatCompletionToolMessageParam

[After]

  • ChatCompletionMessageParam.SystemMessageParam
  • ChatCompletionMessageParam.UserMessageParam
  • ChatCompletionMessageParam.AssistantMessageParam
  • ChatCompletionMessageParam.ToolMessageParam

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant