Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update moderations results keywords, abstract display of moderations keywords #162

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

kalafus
Copy link
Contributor

@kalafus kalafus commented Feb 5, 2024

What

update moderations results keywords, abstract display of moderations keywords

Why

4 moderations keywords were missing

Affected Areas

ModerationsResults, demo

@ingvarus-bc
Copy link
Contributor

Hi, @kalafus, thanks for your PR! 🔥
Looks great! Though, what do you think of keeping everything in CamelCase?
Just for consistency, so that the code is in more Swifty way

@kalafus
Copy link
Contributor Author

kalafus commented Feb 15, 2024

sure thing.

got a more concise way to do the Iterator? Reflection is no longer a concise way to flit through these.

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ingvarus-bc ingvarus-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job there 🔥
Thank you!

@ingvarus-bc ingvarus-bc merged commit edf8830 into MacPaw:main Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants