Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent json decoding error when streaming #154

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

neelvirdy
Copy link
Contributor

@neelvirdy neelvirdy commented Jan 31, 2024

What

Filter empty json content after trimming whitespace instead of before

Why

Addresses #128 and #153

Affected Areas

--

Fix inspired by this comment #151 (comment)

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

@ruben-storyarc-studios ruben-storyarc-studios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! for doing this This fixes it on my app as well

Copy link

@manurueda manurueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@ingvarus-bc
Copy link
Contributor

Thanks for the fix! 🔥

@ingvarus-bc ingvarus-bc merged commit 60dfce4 into MacPaw:main Feb 2, 2024
4 checks passed
@csmac3144
Copy link

Same issue -- when can we expect an update to the package?

@manurueda
Copy link

already merged @csmac3144

@neelvirdy neelvirdy deleted the fix/json-decoding-error branch February 2, 2024 20:20
@ryanrapp ryanrapp mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants