Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for python 3.13 #2173

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Oct 8, 2024

What does this PR do?

This PR adds support for Python 3.13.

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@afuetterer afuetterer marked this pull request as draft October 8, 2024 17:42
@afuetterer
Copy link
Contributor Author

This is still blocked by dependencies not being ready for 3.13.

@afuetterer afuetterer marked this pull request as ready for review January 25, 2025 14:21
@afuetterer
Copy link
Contributor Author

Finally.

Now you have 167 warnings when testing Python 3.13. You have DeprecationWarnings and FutureWarnings.

See: https://github.com/MaartenGr/BERTopic/actions/runs/12965576901/job/36165467740?pr=2173#step:5:44

@MaartenGr
Copy link
Owner

@afuetterer Thanks for checking this! I'll make sure to merge this. It's going to be quite a bit of work to remove all of those warnings (mostly the deprecation warnings) but for now I'm happy that we can support 3.13, thanks!

@MaartenGr MaartenGr merged commit 0a5d1fb into MaartenGr:master Jan 26, 2025
6 checks passed
@afuetterer afuetterer deleted the python-313 branch January 26, 2025 10:39
@afuetterer
Copy link
Contributor Author

I think quite a few of those warnings are actually the same, so fixable by changing one line in BERTopic, e.g.

tests/test_bertopic.py: 18 warnings /home/runner/work/BERTopic/BERTopic/bertopic/_bertopic.py:3467: DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement 'dtype' and 'copy' keyword arguments.

18 warnings from the same line. It should be possible to address those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants