Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client for erdbeere #748
base: dev
Are you sure you want to change the base?
Add client for erdbeere #748
Changes from all commits
7de7f0f
7377d20
011a6ef
27ed46c
b202577
4638543
9feb96c
d39a7ac
536ff68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an endpoint cannot be reached (e.g. locally kill the erdbeere docker container), we get an error on this page: http://localhost:3000/lectures/1/show_structures
In this case, we could show a nice error message to the user saying that the erdbeere server that hosts the examples is unfortunately not reachable at the moment, otherwise we might be spammed with these errors in our email box and it's not the best experience for the user neither. In addition, we could be informed by email via the erdbeere service itself that it is down.
Or we might reserve this better error handling for later and just get erdbeere up and running for now ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that error handling is graceful in case of editing a lecture via http://localhost:3000/lectures/1/edit#info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added better error handling in the latest commit. Please check if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠ In production, how does MaMpf communicate with the Erdbeere server? Is Erdbeere just available on localhost or also available to the word-wide web. In the latter case, how does MaMpf authenticate at Erdbeere? I'm wondering in particular since Erdbeere itself has a frontend which allows to log in.