Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lecture creation #741

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Jan 31, 2025

Closes #738. The problem was a wrong multiple: true statement introduced in the 2nd voucher PR #671. Beforehand this attribute wasn't set and thus defaulted to false (like it is supposed to be).

I've also added a new cypress test to test that admins can create new lectures. To do so in an empty database, I had to give admins the ability for this, even when they are not course editors. (In the future, we could think of simply giving admins rights to every endpoint.) I've also had to adjust another test that made use of the helper function where the multiple: true was used. In that case, the behavior was a bit broken too, since we allowed users to select multiple teachers although just one is accepted by the backend.

Out of scope:

  • In the test, I had to select an option from a TomSelect dropdown. I've added a respective cypress command that we can reuse from now on.
  • I also added a missing right to docker buildx.
  • Furthermore, we set the experimentalRunAllSpecs flag to true such that we can through all cypress tests at once locally.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.26%. Comparing base (23aae01) to head (8df92a3).
Report is 1 commits behind head on release/1.15.2-first.

Files with missing lines Patch % Lines
app/abilities/lecture_ability.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/1.15.2-first     #741   +/-   ##
=====================================================
  Coverage                 54.26%   54.26%           
=====================================================
  Files                       170      170           
  Lines                      7356     7356           
=====================================================
  Hits                       3992     3992           
  Misses                     3364     3364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Splines Splines merged commit af33e36 into release/1.15.2-first Jan 31, 2025
4 checks passed
@Splines Splines deleted the fix/create-new-course branch January 31, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants