-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new lecture creation #741
Conversation
Also use random names for the course
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.15.2-first #741 +/- ##
=====================================================
Coverage 54.26% 54.26%
=====================================================
Files 170 170
Lines 7356 7356
=====================================================
Hits 3992 3992
Misses 3364 3364 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Closes #738. The problem was a wrong
multiple: true
statement introduced in the 2nd voucher PR #671. Beforehand this attribute wasn't set and thus defaulted tofalse
(like it is supposed to be).I've also added a new cypress test to test that admins can create new lectures. To do so in an empty database, I had to give admins the ability for this, even when they are not course editors. (In the future, we could think of simply giving admins rights to every endpoint.) I've also had to adjust another test that made use of the helper function where the
multiple: true
was used. In that case, the behavior was a bit broken too, since we allowed users to select multiple teachers although just one is accepted by the backend.Out of scope:
docker buildx
.experimentalRunAllSpecs
flag to true such that we can through all cypress tests at once locally.