Upgrade Rails, Ruby, bootstrap and fix some issues #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splines
requested changes
Feb 16, 2025
There was a problem hiding this comment.
As discussed face-to-face I didn't work through this Erdbeere pull request in detail. On the MaMpf side, I verified that the functionality provided via the API endpoints here is working as expected.
Splines
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Nice! I've also linked to your comment referring to action cable from here.
Note that StackOverflow post titles might change, while the ids do not. That's why using the Share button under a StackOverflow question or a comment is preferred to just copy the browser URL.
Splines
approved these changes
Feb 16, 2025
Splines
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring erdbeere into the year 2025. It contains upgrades to
and contains several bugfixes.
Respective PR on the MaMpf side: MaMpf-HD/mampf#748