Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiazuo_Zhang hw3 #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JZZhang04
Copy link

No description provided.

Copy link
Member

@rossbernet rossbernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good - few small changes would make it more complete.


for (var i = 1; i <= 100; i = i+1) {
if (i%3 == 0 && i%5 != 0) {
console.log('Fizz');}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results should look like this:

image

Yours look like this:

image

You need to print out the numbers not divisible by 3 or 5 also

//if (bikeArrayClean[i][3] > 20) {
var add_loc = [];
add_loc.push(bikeArrayClean[i][1]);
add_loc.push(bikeArrayClean[i][0]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you used the BikeArrayDirty to count, but not to actually add data to the map:

image

image

image

The last image is what happened when I switched it to dirty data...so you were very close...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants