HW3 - Buckler #17
Open
HW3 - Buckler #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding lab1/part3 - yes. There are some really easy ways to sort of do this, and some much more involved ways to do this really well. This is an extremely good solution: |
rossbernet
approved these changes
Feb 11, 2019
|
|
||
| console.log('Which games are owned by both Ross and Nathan', query7); | ||
|
|
||
| /* ===================== | ||
| Which games are exclusive to collections? In other words, only owned by either Ross or Nathan. | ||
| ===================== */ | ||
|
|
||
| var query8; | ||
| var query8 = _.difference(rossGameList, nathanGameList); |
There was a problem hiding this comment.
difference is insufficient here to capture the games that Nathan has that Ross does not have.
| } else {n=1}; | ||
| temp.push(obj[n], obj[n+1]); | ||
| if(typeof obj[n+2] === 'string') { | ||
| if(!obj[n+2].includes('stations')) { |
There was a problem hiding this comment.
The solution I pointed you earlier ---
basically does a loop in a loop to check every single entry. And checks to see if they are numbers doing something similar to what you've done. You have a pretty good solution here - if you really want additional feedback we can try to call @moradology (this is in reference to @bucklerd s comment on the pull request if there is a better way to do this bike data cleaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendations to streamline the 'cleaning' function I used in Lab1 part 3 (~ line 70). It works well, but seems a little cluncky. Suggestions welcome.