Week3 Yufei Yuan #15
Open
Week3 Yufei Yuan #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
requested changes
Feb 11, 2019
lab/lab1/part1-array-access.html
Outdated
| TempArr.unshift(header); | ||
| for (i=0; i < TempArr.length; i++){console.log(TempArr[i])}; | ||
| var makeAMarker = (obj) => {return L.marker([obj[0], obj[1]]).bindPopup(obj[2])} | ||
| for (var i=1; i <= TempArr.length; i++){ makeAMarker(TempArr[i]).addTo(map) } |
There was a problem hiding this comment.
<= is giving this error:
Try without the = it resolves the issue.
There was a problem hiding this comment.
Changed. This solved the propblem!
|
|
||
|
|
||
|
|
||
| //for clean data |
There was a problem hiding this comment.
Nothing appears on the map when I load the page:
part3-data-transformation.html
Does it work for you?
| x = y; | ||
| y = z; | ||
| } | ||
| console.log(evenSum); |
There was a problem hiding this comment.
You are close... But you didn't get the right answer...1089154..
Take a look: https://stackoverflow.com/questions/9053545/finding-the-sum-of-even-valued-terms-in-fibonacci-sequence
lab/lab2/part1.js
Outdated
| console.log('Which games are owned by both Ross and Nathan', query7); | ||
|
|
||
| /* ===================== | ||
| Which games are exclusive to collections? In other words, only owned by either Ross or Nathan. | ||
| ===================== */ | ||
|
|
||
| var query8; | ||
|
|
||
| var query8 = _.union(_.difference(rossGameList, nathanGameList), _.difference(rossGameList, nathanGameList)); |
There was a problem hiding this comment.
you are taking a union of two things that are the same.
Try switching the order of the inputs on one of the difference queries and see if the result changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.