Add new algo audio2midi #1437
Open
Add new algo audio2midi #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogdanov
requested changes
Oct 30, 2024
Comment on lines
+215
to
+222
| if sys.platform == "darwin": | ||
| import soundfile as sf | ||
|
|
||
| audio, _ = sf.read(filename, dtype="float32") | ||
| if audio.ndim > 1: | ||
| audio = audio[:, 0] | ||
| else: | ||
| audio = MonoLoader(filename=filename, sampleRate=sample_rate)() |
There was a problem hiding this comment.
Use MonoLoader for both cases for consistency and also to avoid additional dependency.
There was a problem hiding this comment.
Right, but I'm running tests in OSX. So, I need it to run them. Once we resolve all comments I might remove it. Let's fix the other parts and I will do it.
Comment on lines
+44
to
+47
| n_notes_tolerance: int = 0, | ||
| onset_tolerance: float = 0.01, | ||
| offset_tolerance: float = 0.01, | ||
| midi_note_tolerance: int = 0, |
There was a problem hiding this comment.
This can be hardcoded inside asserts directly
There was a problem hiding this comment.
No, it cannot because it is inside runARealCase() which receive different values for those parameters. If we hardcoded some tests will fail. I can remove the default value, that would be okay.
There was a problem hiding this comment.
Please resolve or suggest any others changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes header, cpp and unittests.