PitchYinFFT updates (new weighting parameter, do not throw exception on empty peak detection) #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogdanov
reviewed
Feb 8, 2024
| @@ -189,8 +245,9 @@ void PitchYinFFT::compute() { | |||
| yinMin = -_amplitudes[0]; | |||
| } | |||
| else { | |||
| // TODO this should never happen, but some people reported it happening in their real time applications. | |||
| throw EssentiaException("PitchYinFFT: it appears that no peaks were found by PeakDetection. If you read this message, PLEASE, report this issue to the developers with an example of audio on which it happened."); | |||
| tau = 0.0; // it will provide zero-pitch and zero-pitch confidence. | |||
There was a problem hiding this comment.
This change is out of scope of weighting functions. At least would should add the description of this change to the PR, or move it to a separate PR if you have more updates to group it with.
There was a problem hiding this comment.
Oh yes! this is something we need in the ODISEI project to avoid a crucial error. Indeed we would need to launch a negative pitch value. No problem I will redo what essentia does in this cases.
There was a problem hiding this comment.
This change had been already included in the merge.
dbogdanov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add weighting parameter to select different weighting funcitons in PITCHYINFFT algorithm. The available choices are:
Note that there is no experimental validation of better pitch estimation performance with new alternative weightings.
Change behavior on empty spectrum peak detection: output zero pitch and confidence instead of throwing an exception.
@dbogdanov Edited for completeness.