chore(frontend): manually compile with tsconfig.build.json before run…

…ning react-scripts

frontend/craco.config.js

@@ -6,23 +6,30 @@ module.exports = {
       // See https://github.com/alex3165/react-mapbox-gl/issues/931
       // See https://github.com/mapbox/mapbox-gl-js/issues/10565
       // eslint-disable-next-line import/no-webpack-loader-syntax
-      ignore: ['./node_modules/maplibre-gl/dist/maplibre-gl.js'],
-    },
+      ignore: ['./node_modules/maplibre-gl/dist/maplibre-gl.js']
+    }
+  },
+  typescript: {
+    // Disable type checking by react-scripts because it takes tsconfig.json
+    // blindlessly, and compiles tests and mocks, although it should not.
+    // Instead, we manually compile with tsconfig.build.json,
+    // as we would do using vite.
+    enableTypeChecking: false
   },
   jest: {
     configure(config) {
       config.rootDir = '.';
       config.setupFiles = ['<rootDir>/jest.polyfills.js'];
       config.setupFilesAfterEnv = [
         'jest-extended/all',
-        '<rootDir>/src/setupTests.ts',
+        '<rootDir>/src/setupTests.ts'
       ];
       config.testTimeout = 30_000;
       config.transformIgnorePatterns = [
         '<rootDir>/node_modules/(?!@codegouvfr)/.+\\.js$',
-        '<rootDir>/node_modules/.store/(?!@codegouvfr)/.+\\.js$',
+        '<rootDir>/node_modules/.store/(?!@codegouvfr)/.+\\.js$'
       ];
       return config;
-    },
-  },
+    }
+  }
 };

frontend/package.json

@@ -3,7 +3,7 @@
   "scripts": {
     "clean": "rimraf build",
     "icons": "only-include-used-icons",
-    "build": "yarn clean && yarn icons && DISABLE_ESLINT_PLUGIN=true craco build",
+    "build": "yarn clean && yarn icons && tsc -b tsconfig.build.json && DISABLE_ESLINT_PLUGIN=true craco build",
     "dev": "yarn icons && DISABLE_ESLINT_PLUGIN=true craco start",
     "test": "DISABLE_ESLINT_PLUGIN=true craco test",
     "postinstall": "copy-dsfr-to-public"

frontend/tsconfig.build.json

@@ -1,7 +1,12 @@
 {
   "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "moduleResolution": "bundler"
-  },
-  "exclude": ["node_modules", "dist","src/**/*.test.ts", "src/**/*.test.tsx"]
+  "exclude": [
+    "node_modules",
+    "build",
+    "src/mocks/**/*.ts",
+    "src/setupTests.ts",
+    "src/**/*.test.ts",
+    "src/**/*.test.tsx",
+    "test/fixtures.test.ts"
+  ]
 }

frontend/tsconfig.json

@@ -1,7 +1,4 @@
 {
   "extends": "@tsconfig/create-react-app/tsconfig.json",
-  "compilerOptions": {
-    "moduleResolution": "node"
-  },
   "include": ["src"]
 }