fix: tests and query filters

MTES-MCT · Oct 8, 2024 · 87ecd7f · 87ecd7f
1 parent 36dc7d1
commit 87ecd7f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/server/src/controllers/housingController.test.ts b/server/src/controllers/housingController.test.ts
@@ -96,7 +96,7 @@ describe('Housing API', () => {
       const { body, status } = await request(app)
         .get(testRoute)
         .query({
-          filters: {}
+          filters: JSON.stringify({})
         })
         .use(tokenProvider(user));
 
@@ -131,6 +131,7 @@ describe('Housing API', () => {
       const { body, status } = await request(app)
         .get(testRoute)
         .query({
+          paginate: true,
           page: 1,
           perPage: 1
         })

diff --git a/server/src/controllers/housingController.ts b/server/src/controllers/housingController.ts
@@ -97,9 +97,7 @@ async function list(
   const sort = sortApi.parse<HousingSortableApi>(
     request.query.sort as string[] | undefined
   );
-
-  const rawFilters = JSON.parse(query.filters);
-
+  const rawFilters = query.filters !== undefined ? JSON.parse(query.filters) : undefined;
   const filters: HousingFiltersApi = {
     ...rawFilters,
     multiOwners: rawFilters?.multiOwners?.map((value: string) =>

diff --git a/server/src/routers/protected.ts b/server/src/routers/protected.ts
@@ -36,7 +36,6 @@ router.use(userCheck());
 
 router.post('/files', upload(), fileController.create);
 
-// TODO: replace by GET /housing
 router.get(
   '/housing',
   validatorNext.validate({