Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: permettre de mettre à jour l'Emport direct de DASRI quand l'email de contact est une chaîne vide #3641

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

providenz
Copy link
Member

@providenz providenz commented Oct 7, 2024

Le passage à zod (contactEmail: z.string().email().nullish()) a entraîné un effet de bord: pour un établissement dont contactEmail est une chaîne vide, la mise à jour de allowBsdasriTakeOverWithoutSignature lève une erreur

Bug

2024-10-07_22-53-00.mp4

Fix

2024-10-07_22-53-40.mp4
  • Mettre à jour la documentation
  • Mettre à jour le change log
  • Documenter les manipulations à faire lors de la mise en production (sur le ticket Favro de release)
  • S'assurer que la numérotation des nouvelles migrations est bien cohérente
  • Informer le data engineer de tout changement de schéma DB

Copy link

sonarcloud bot commented Oct 7, 2024

@providenz providenz merged commit f44b654 into master Oct 8, 2024
17 of 18 checks passed
@providenz providenz deleted the hotfix/update-dasri-takeover-without-signature branch October 8, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants