-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRA-13729] Adds page titles #3639
base: dev
Are you sure you want to change the base?
Conversation
Quality Gate failedFailed conditions |
|
||
const matches = matchRoutes(paths, currentLocation); | ||
|
||
const title = titles[matches ? matches[0].route.path : "default"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On doit avoir un petit glitch ici: quand title vaut "", le title de la page devient vide 'au lieu d'un "Trackdechets" générique) et ff par exemple va exemple afficher le path eg domain.tld/registre)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha oui, effectivement, bien vu ! J'attends des titres à compléter dans la liste, je fixerai ça en les updatant !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf comment
En attente de certaines URLs