-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sécurité] Cloisonnement des rôles #798
Open
emilschn
wants to merge
3
commits into
develop
Choose a base branch
from
fix/797-secure-roles
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| <?php | ||
|
|
||
| namespace App\Security\Voter; | ||
|
|
||
| use App\Entity\Intervention; | ||
| use Symfony\Component\Security\Core\Authentication\Token\TokenInterface; | ||
| use Symfony\Component\Security\Core\Authorization\Voter\Voter; | ||
| use Symfony\Component\Security\Core\User\UserInterface; | ||
|
|
||
| class InterventionVoter extends Voter | ||
| { | ||
| public const SEND_ESTIMATION = 'INTERVENTION_SEND_ESTIMATION'; | ||
| public const RESOLVE = 'INTERVENTION_RESOLVE'; | ||
| public const STOP = 'INTERVENTION_STOP'; | ||
|
|
||
| protected function supports(string $attribute, $subject): bool | ||
| { | ||
| return \in_array($attribute, [self::RESOLVE, self::SEND_ESTIMATION, self::STOP]) && $subject instanceof Intervention; | ||
| } | ||
|
|
||
| protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool | ||
| { | ||
| $user = $token->getUser(); | ||
| if (!($user instanceof UserInterface)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (self::RESOLVE == $attribute) { | ||
| return $this->canResolve($subject); | ||
| } | ||
|
|
||
| if (self::SEND_ESTIMATION == $attribute) { | ||
| return $this->canSendEstimation($subject); | ||
| } | ||
|
|
||
| if (self::STOP == $attribute) { | ||
| return $this->canStop($subject); | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private function canResolve(Intervention $intervention): bool | ||
| { | ||
| $signalement = $intervention->getSignalement(); | ||
|
|
||
| if (!$signalement->getResolvedAt() | ||
| && !$signalement->getClosedAt() | ||
| && $intervention->isAccepted() | ||
| && $intervention->getEstimationSentAt() | ||
| && !$intervention->getCanceledByEntrepriseAt() | ||
| && $intervention->isAcceptedByUsager() | ||
| && !$intervention->getResolvedByEntrepriseAt()) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private function canSendEstimation(Intervention $intervention): bool | ||
| { | ||
| if ($intervention->isAccepted()) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private function canStop(Intervention $intervention): bool | ||
| { | ||
| $signalement = $intervention->getSignalement(); | ||
|
|
||
| if (!$signalement->getResolvedAt() | ||
| && !$signalement->getClosedAt() | ||
| && $intervention->isAccepted() | ||
| && $intervention->getEstimationSentAt() | ||
| && !$intervention->getCanceledByEntrepriseAt() | ||
| && ($intervention->getChoiceByEntrepriseAt() || $intervention->isAcceptedByUsager()) | ||
| && !$signalement->getTypeIntervention()) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| <?php | ||
|
|
||
| namespace App\Security\Voter; | ||
|
|
||
| use App\Entity\Enum\Role; | ||
| use App\Entity\Signalement; | ||
| use App\Repository\InterventionRepository; | ||
| use Symfony\Bundle\SecurityBundle\Security; | ||
| use Symfony\Component\Security\Core\Authentication\Token\TokenInterface; | ||
| use Symfony\Component\Security\Core\Authorization\Voter\Voter; | ||
| use Symfony\Component\Security\Core\User\UserInterface; | ||
|
|
||
| class SignalementVoter extends Voter | ||
| { | ||
| public const ACCEPT = 'SIGNALEMENT_ACCEPT'; | ||
| public const CLOSE = 'SIGNALEMENT_CLOSE'; | ||
|
|
||
| public function __construct( | ||
| private Security $security, | ||
| private InterventionRepository $interventionRepository, | ||
| ) { | ||
| } | ||
|
|
||
| protected function supports(string $attribute, $subject): bool | ||
| { | ||
| return \in_array($attribute, [self::ACCEPT, self::CLOSE]) && $subject instanceof Signalement; | ||
| } | ||
|
|
||
| protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool | ||
| { | ||
| $user = $token->getUser(); | ||
| if (!($user instanceof UserInterface)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (self::ACCEPT == $attribute) { | ||
| return $this->canAccept($subject); | ||
| } | ||
|
|
||
| if (self::CLOSE == $attribute) { | ||
| return $this->canClose($subject); | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private function canAccept(Signalement $signalement): bool | ||
| { | ||
| if ($this->security->isGranted(Role::ROLE_ADMIN->value)) { | ||
| return false; | ||
| } | ||
|
|
||
| $acceptedEstimations = $this->interventionRepository->findBy([ | ||
| 'signalement' => $signalement, | ||
| 'acceptedByUsager' => true, | ||
| 'canceledByEntrepriseAt' => null, | ||
| ]); | ||
| if (!$signalement->getResolvedAt() | ||
| && !$signalement->getClosedAt() | ||
| && 0 == \count($acceptedEstimations)) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private function canClose(Signalement $signalement): bool | ||
| { | ||
| if ($this->security->isGranted(Role::ROLE_ADMIN->value) | ||
| && !$signalement->getResolvedAt() | ||
| && !$signalement->getClosedAt()) { | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sauf erreur de ma part ici je peux clôturer n'importe quelle intervention via son id. Il faut rajouter un check avec l'entreprise de l'user connecté (d'ailleurs je peux aussi en tant qu'admin alors que je ne suis pas censé en tant qu'admin mais ca à moins d'importance)