♻️ Ajouter validateur dans l'event NotifierCandidature #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
reviewed
Oct 9, 2024
packages/applications/projectors/src/subscribers/candidature/candidature.projector.ts
Outdated
Show resolved
Hide resolved
| identifiantProjet, | ||
| identifiantUtilisateur: notifiéPar, | ||
| }); | ||
| return; |
There was a problem hiding this comment.
pas sur, on devrait peut-être garder une valeur,même mauvaise (genre "inconnu" ? ) car sinon ces projets resteront à notifier et c'est genant...
There was a problem hiding this comment.
string vide ? "validateur inconnu" ?
There was a problem hiding this comment.
Par contre je peux juste logger le warning pour avoir une trace
There was a problem hiding this comment.
je fais un check de ceux qui nous manquent
benjlevesque
reviewed
Oct 9, 2024
packages/domain/candidature/src/notifier/notifierCandidature.behavior.ts
Show resolved
Hide resolved
benjlevesque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ajouter des informations complémentaires sur l'utilisateur pour la regénération de l'attestation
A merger avant #2284
Type de changement
Veuillez supprimer les options qui ne sont pas pertinentes.
Comment cela a-t-il été testé?
test