🐛 Fix bug w/ process env undefined

MTES-MCT · Apr 2, 2024 · 99defc9 · 99defc9
1 parent 59bc9f0
commit 99defc9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/packages/applications/legacy/.env.template b/packages/applications/legacy/.env.template
@@ -68,6 +68,3 @@ SENTRY_DSN=
 
 # UMAMI
 TRACKER_WEBSITE_ID=
-
-# FEATURE FLAGS
-FEATURE_FLAG_SHOW_GARANTIES_FINANCIERES=
diff --git a/packages/applications/legacy/src/controllers/project/getProjectPage.ts b/packages/applications/legacy/src/controllers/project/getProjectPage.ts
@@ -143,7 +143,7 @@ v1Router.get(
       let garantiesFinancières: ProjectDataForProjectPage['garantiesFinancières'] | undefined =
         undefined;
 
-      if (projet.appelOffre.isSoumisAuxGF) {
+      if (projet.appelOffre.isSoumisAuxGF && process.env.FEATURE_FLAG_SHOW_GARANTIES_FINANCIERES) {
         garantiesFinancières = await getGarantiesFinancières(identifiantProjetValueType);
       }
 

diff --git a/packages/applications/legacy/src/views/pages/projectDetailsPage/sections/InfoGenerales.tsx b/packages/applications/legacy/src/views/pages/projectDetailsPage/sections/InfoGenerales.tsx
@@ -11,8 +11,6 @@ import { afficherDate } from '../../../helpers';
 
 import { GarantiesFinancières } from '@potentiel-domain/laureat';
 
-const { FEATURE_FLAG_SHOW_GARANTIES_FINANCIERES } = process.env;
-
 type InfoGeneralesProps = {
   project: ProjectDataForProjectPage;
   role: UserRole;
@@ -43,7 +41,6 @@ export const InfoGenerales = ({
     puissance < appelOffre.periode.noteThreshold.volumeReserve.puissanceMax;
 
   const shouldDisplayGf =
-    FEATURE_FLAG_SHOW_GARANTIES_FINANCIERES &&
     isClasse &&
     !isAbandoned &&
     [
@@ -60,7 +57,7 @@ export const InfoGenerales = ({
 
   return (
     <Section title="Informations générales" icon={<BuildingIcon />} className="flex gap-5 flex-col">
-      {shouldDisplayGf && garantiesFinancières && (
+      {garantiesFinancières && shouldDisplayGf && (
         <GarantiesFinancièresProjet
           garantiesFinancières={garantiesFinancières}
           project={{