Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Préavis – La saisie des poids d'espadon sur les préavis 0 plante #3747

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Préavis – La saisie des poids d'espadon sur les préavis 0 plante #3747

merged 2 commits into from
Oct 9, 2024

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Oct 8, 2024 •
edited
Loading

@ivangabriele ivangabriele added the bug Something isn't working label Oct 8, 2024
@ivangabriele ivangabriele changed the title Préavis - La saisie des poids d'espadon sur les préavis 0 plante Préavis – La saisie des poids d'espadon sur les préavis 0 plante Oct 8, 2024
@ivangabriele ivangabriele force-pushed the ivan/fix-bluefin-tuna-weight-calculation-in-manual-pno-form branch from 1b5002c to 079e9de Compare October 8, 2024 06:51
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

louptheron
louptheron approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, le code est un peu complexe mais j'imagine qu'il n'y avait pas plus simple, et c'est bien testé

@ivangabriele
Copy link
Member Author

LGTM, le code est un peu complexe mais j'imagine qu'il n'y avait pas plus simple, et c'est bien testé

Oui je ne trouve pas ça non plus idéal. J'ai en effet choisi la solution qui m'a paru la moins prompte aux erreurs. Préférant préparer le données à l'entrée et les re-transformer à la sortie du formulaire plutôt que de hacker Formik.

@ivangabriele ivangabriele merged commit 9500e38 into master Oct 9, 2024
26 checks passed
@ivangabriele ivangabriele deleted the ivan/fix-bluefin-tuna-weight-calculation-in-manual-pno-form branch October 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Préavis - La saisie des poids d'espadon sur les préavis 0 plante
2 participants
@ivangabriele @louptheron