Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signalements] Laisser les signalements affichés sur la carte lors du dessin d'un point ou d'une zone d'un signalement #2043

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

claire2212
Copy link
Collaborator

@claire2212 claire2212 added the feat. enhancement Amélioration/évolution d'une fonctionnalité label Jan 24, 2025
@claire2212 claire2212 self-assigned this Jan 24, 2025
if (
drawListener === InteractionListener.MISSION_ZONE ||
drawListener === InteractionListener.SURVEILLANCE_ZONE ||
drawListener === InteractionListener.CONTROL_POINT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: ne manque-t'il pas REPORTING_POINT = 'REPORTING_POINT' et REPORTING_ZONE = 'REPORTING_ZONE',

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non justement, quand on dessine un signalement on veut que les autres signalement restent affichés (ici, dans cette condition, on affiche seulement les signalements rattachés à une mission).
Nous on veut tomber dans le dernier return

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compris 👍

@claire2212 claire2212 merged commit 2f437a7 into main Jan 28, 2025
26 checks passed
@claire2212 claire2212 deleted the claire/dont-hide-other-reportings-when-draw-point branch January 28, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat. enhancement Amélioration/évolution d'une fonctionnalité
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signalement - laisser les signalements visibles sur la carte lors de l'ajout d'un nouveau signalement
2 participants