Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mission] Ne pas empêcher la création/modification d'une mission s'il y a un souci pour publier l'événement de mise à jour #2039

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

claire2212
Copy link
Collaborator

No description provided.

@claire2212 claire2212 added the bug Something isn't working label Jan 23, 2025
@claire2212 claire2212 self-assigned this Jan 23, 2025
@claire2212 claire2212 requested a review from louptheron January 24, 2025 14:10
@claire2212
Copy link
Collaborator Author

claire2212 commented Jan 24, 2025

@maximeperraultdev , Loup a vu qu'on pouvait passer le publishEvent en asynchrone c'est ce que j'ai fait dans le dernier commit), plus besoin des try/catch.

Par contre pour les tests unitaires j'ai un souci je ne sais pas comment throw l'exception du sseEmitter. Si vous avez des idées, @maximeperraultdev , @louptheron je suis preneuse.

Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@claire2212 claire2212 merged commit 9a1ca8d into main Jan 28, 2025
26 checks passed
@claire2212 claire2212 deleted the claire/fix-duplicate-mission branch January 28, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants