Fléchage du département à la place du simulateur sur la home (GUH - V1.3) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyDez
commented
Oct 1, 2024
thibault
approved these changes
Oct 7, 2024
envergo/moulinette/models.py
Outdated
| @@ -709,6 +710,39 @@ def __str__(self): | |||
| return self.department.get_department_display() | |||
|
|
|||
|
|
|||
| class HaieDepartmentConfig(models.Model): | |||
There was a problem hiding this comment.
Question : est-ce que tu as considéré le fait d'avoir un objet commun dont hériteraient les objets config pour aménagement et haie ?
Ici, on a un objet MoulinetteConfig qui ne sert que pour aménagement tandis que HaieDepartementConfig sert pour haie. J'ai l'impression qu'on manque un peu de cohérence dans le nommage des classes, qu'en penses-tu ?
There was a problem hiding this comment.
(pour l'historique : vu en discussion privée)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ce tikcet