Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update finishing #906

Merged
merged 8 commits into from
Jan 30, 2025
Merged

feat: update finishing #906

merged 8 commits into from
Jan 30, 2025

Conversation

paulboosz
Copy link
Collaborator

@paulboosz paulboosz commented Jan 21, 2025

πŸ”§ Problem

ecobalyse-data PR : Merged βœ…

User Story

Values come from this part of the doc
image

🚨 Points to watch/comments

We have to convert kWh to MJ :
0.6 kWh = 2.16 MJ

🏝️ How to test

  • PO validation

@paulboosz paulboosz requested a review from n1k0 January 29, 2025 15:08
@paulboosz
Copy link
Collaborator Author

image

Validation OK

Copy link
Member

@n1k0 n1k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated live with Pascal, Paul and Camille over Zoom.

@paulboosz paulboosz merged commit 6ca2b00 into master Jan 30, 2025
6 checks passed
@paulboosz paulboosz deleted the feat/update-finishing branch January 30, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants