Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase Quality: Fixed various issues with code documentation and formatting. #41

Merged
merged 51 commits into from
Mar 13, 2024
Merged

Codebase Quality: Fixed various issues with code documentation and formatting. #41

merged 51 commits into from
Mar 13, 2024

Conversation

lunathanael
Copy link
Collaborator

@lunathanael lunathanael commented Mar 12, 2024 •
edited
Loading

Used Pylint to fix various documentation issues, and create new GitHub issues for those not directly addressed. I tried to review the entire codebase and cover everything but I'm sure I missed a lot.
Please double-check that all details from the issue were addressed and the code is functional.

Created Issues: #33 #34 #35 #36 #37 #38 #39 #40

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Missing module/class dependencies. #26

Validation
How did you test these changes?

  • Did you run the python notebook and test your changes?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any dependencies that have yet to be constructed?
    Relies on ...
  • Are there any other steps that were used to validate these changes?
    1. Unit/Function
    2. Discuss with AI side

Screenshots (optional)
Add screenshots here.
Better score :)
image

@lunathanael
deleted changes.md, fixed super() call
90fe18e
@lunathanael
fixing types and bugs from previous prs
14c315c
@lunathanael
fixing entity documentation and using fstrings, added more type annot…
54132c6 
…ations
@lunathanael
fixed spelling errors
7d7c090
@lunathanael
Entitiy collection stop method corrected spelling error
7fa3871
@lunathanael
fixed _load_entity entity loading method
d12e8b5
@lunathanael
fixed mod->entity artifacts, fixed entities spelling error
4a4982b
@lunathanael
entity.py linting finished
5912e13
@lunathanael
entity.py is actually done now
b9037ce
@lunathanael
added none return type to entity.py
14585b4
@lunathanael
shorten line length, rename __init__.py
5640449
@lunathanael
rename __init__.py
36f254a
@lunathanael
rename tentity->target_entity in entity_distance in attack.py
8b86e1c
@lunathanael
rename target_ent to target_entity
381b8c0
@lunathanael
linted movement.py
ca03d75
@lunathanael
rename target_entity
876fc0d
@lunathanael
linted file and spelling errors
3140342
@lunathanael
renamed arena.py
e77cd9d
@lunathanael
linted arena.py
a13dbed
@lunathanael
card added newline, missing module docstring
833f32e
@lunathanael
removed entity collection inheretance in game_engine
048f761
@lunathanael
fixed game engine dangerous default value
f3b7f0b
@lunathanael
fixed list typing in player.py
c417893
@lunathanael
linted init
f88e1c0
@lunathanael
missing entity stuff
eadca1b
@lunathanael
added template playcard function
76794d6
@lunathanael
removed assert space
901638a
@lunathanael
added fps to initializer player
34469dd
@lunathanael
adding pseudovalues for return value of template functions
f9a3c18
@lunathanael
updated card.py
1fe63a4
@lunathanael
added is_game_over template function in struct
4569c39
@lunathanael
added tower_count function
4f88b04
@lunathanael
updated game_scheduler type annotation
f9d0aea
@lunathanael
finished game_engine linting
ac5f441
@lunathanael
added L to list in pseudo legal cards return type
138a8e1
@lunathanael
changed elixir to type float
653d70b
@lunathanael
fixed pseudolegalcards to be card_index and not card
d089218
@lunathanael
added is_overtime template function
0e1344b
@lunathanael
added line after docstring
ea61435
@lunathanael
added extra check
dea1078
@lunathanael
added elixir cost for template
18e8a10
@lunathanael
finished linting player
09ea9ba
@lunathanael
added newline after docstring
927cf90
@lunathanael
missing stuff in struct
7c225ee
@lunathanael
renamed clash_royale_env class
a5065e9
@lunathanael
give up on clash_royale_env for now
c2bf698
@lunathanael
add module dependencies for pylint github actions
4822ed1
@lunathanael
fixed pyling yml
00c7634
@lunathanael
cleared clashRoyaleEnv code, we can review the commits if we need it …
b7ecab8 
…back
@lunathanael lunathanael added bug Something isn't working crash Bug reports involving a crash dependencies Pull requests that update a dependency file/library feature request help wanted Extra attention is needed needs-review documentation labels Mar 12, 2024
@lunathanael lunathanael requested a review from OwenCochell March 12, 2024 01:14
@lunathanael
Copy link
Collaborator Author

Force merging to continue making progress, still pending review from @OwenCochell

@lunathanael lunathanael merged commit 1cd23be into main Mar 13, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenCochell OwenCochell Awaiting requested review from OwenCochell

Assignees
No one assigned
Labels
bug Something isn't working crash Bug reports involving a crash dependencies Pull requests that update a dependency file/library documentation feature request help wanted Extra attention is needed needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Missing module/class dependencies.
1 participant
@lunathanael