Fix git version mismatch logic with shallow clones #3006
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
FindVersion.cmake
usesgit describe
to find the git commit and tags of the project. Previously, we were mistakenly aborting the configuration of the project whengit describe
returned an error. This PR fixes that by checking the version mismatch only if the parsing of the git tag and commit is successful. A warning is emitted otherwise.Closes #3000